Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(network): refining the connection limit #849

Merged
merged 8 commits into from
Dec 11, 2023
Merged

fix(network): refining the connection limit #849

merged 8 commits into from
Dec 11, 2023

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Dec 11, 2023

Description

This PR includes the following changes:

  • Refines the maximum connection limit.
  • Eliminates the need for users to define a minimum connection limit.
  • Normalizes and logarithmically scales the maximum connection limit for improved results.

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

Merging #849 (7dcbcd3) into main (50d3af1) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
+ Coverage   83.13%   83.16%   +0.02%     
==========================================
  Files         170      170              
  Lines        8556     8552       -4     
==========================================
- Hits         7113     7112       -1     
+ Misses       1102     1100       -2     
+ Partials      341      340       -1

@b00f
Copy link
Collaborator Author

b00f commented Dec 11, 2023

Discussion about the connection limit can be found here: libp2p/go-libp2p#2616

kehiy
kehiy requested changes Dec 11, 2023
View reviewed changes
network/peermgr.go Outdated Show resolved Hide resolved
network/peermgr.go Outdated Show resolved Hide resolved
kehiy
kehiy approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b00f looks good to me.

amirvalhalla
amirvalhalla requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@amirvalhalla amirvalhalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b00f please resolve requested changes.

@themantre themantre merged commit eb06932 into pactus-project:main Dec 11, 2023
12 checks passed
@b00f b00f deleted the scaled-max-conns branch December 11, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kehiy kehiy kehiy approved these changes

@amirvalhalla amirvalhalla amirvalhalla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b00f @kehiy @amirvalhalla @themantre